V1 fix entrypoint schema #613
Open
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
keithmanville
requested changes
Jan 13, 2025
| @@ -151,8 +151,10 @@ class EntrypointMutableFieldsSchema(Schema): | |||
| fields.Integer(), | |||
| attribute="queue_ids", | |||
| data_key="queues", | |||
| allow_none=True, | |||
| metadata=dict(description="The queue for the entrypoint."), | ||
| load_only=True, | ||
| load_default=list(), |
There was a problem hiding this comment.
Not quite right, should be just list.
Part of docs showing that a callable can be used in load_default/dump_default argument: https://marshmallow.readthedocs.io/en/stable/quickstart.html#specifying-defaults
jkglasbrenner
force-pushed
the
v1-fix-entrypoint-schema
branch
from
495a710 to
af63c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for registration of entrypoints without including queues in request. Test coverage added.